Skip to content

feat: Implement go mod proxy strategy #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alecthomas merged 8 commits into from
Jan 21, 2026
Merged

feat: Implement go mod proxy strategy #43

alecthomas merged 8 commits into from
Jan 21, 2026

Conversation

@js-murph
Copy link
Collaborator

@js-murph js-murph commented Jan 20, 2026

What

Implements a caching strategy for the Go module proxy as described in https://proxy.golang.org/

Why

To add support for caching go modules

Tests

Implemented unit tests. In addition manual testing was performed as follows...

  1. Create a cachew.hcl:
memory {}

disk {
  root = "./state/cache"
}

gomod {
  proxy = "https://proxy.golang.org"
}

  1. Run the proxy ./cachewd --config cachew.hcl

  2. Manual verification...

$ time curl http://localhost:8080/github.com/alecthomas/kong/@latest
{"Version":"v1.13.0","Time":"2025-11-12T21:31:44Z","Origin":{"VCS":"git","URL":"https://github.com/alecthomas/kong","Hash":"d8de683664a2581e93717b7e4e8f4b55e4beeff4","Ref":"refs/tags/v1.13.0"}}
real	0m0.179s
user	0m0.006s
sys	0m0.011s

$ time curl http://localhost:8080/github.com/alecthomas/kong/@latest
{"Version":"v1.13.0","Time":"2025-11-12T21:31:44Z","Origin":{"VCS":"git","URL":"https://github.com/alecthomas/kong","Hash":"d8de683664a2581e93717b7e4e8f4b55e4beeff4","Ref":"refs/tags/v1.13.0"}}
real	0m0.033s
user	0m0.006s
sys	0m0.013s

@js-murph js-murph requested a review from alecthomas as a code owner January 20, 2026 05:00
@js-murph js-murph added the enhancement New feature or request label Jan 20, 2026
alecthomas
alecthomas reviewed Jan 20, 2026
View reviewed changes
@alecthomas alecthomas mentioned this pull request Jan 20, 2026
Merged
@alecthomas
Copy link
Collaborator

alecthomas commented Jan 21, 2026

I had another thought - I think we should enforce private repository blocking here, to prevent leaking to upstream public module proxies.

@alecthomas
Copy link
Collaborator

alecthomas commented Jan 21, 2026

Which did also lead me to wonder whether we should be implementing a full proxy...but I think that's a question for another time.

@alecthomas
Copy link
Collaborator

alecthomas commented Jan 21, 2026

Actually... https://github.com/goproxy/goproxy is explicitly designed to be embeddable, and has an extensible caching interface. Let's do some due diligence around whether this would be worthwhile to embed.

The advantage this could give us is the ability to cache private repositories.

@js-murph
Copy link
Collaborator Author

js-murph commented Jan 21, 2026 

Actually... https://github.com/goproxy/goproxy is explicitly designed to be embeddable, and has an extensible caching interface. Let's do some due diligence around whether this would be worthwhile to embed.

The advantage this could give us is the ability to cache private repositories.

Sounds reasonable to me, did we want to merge this as a currently working thing and I can explore the embedded goproxy to replace it?

@alecthomas
Copy link
Collaborator

alecthomas commented Jan 21, 2026

Yeah let's do it!

@alecthomas alecthomas merged commit 40b1af3 into main Jan 21, 2026
5 of 6 checks passed
@alecthomas alecthomas deleted the johnm/implement-go-mod branch January 21, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecthomas alecthomas alecthomas left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@js-murph @alecthomas